Skip to content

fix: sanitize emojis#20

Merged
Bojan131 merged 1 commit into
feature/vector-dbfrom
fix/sanitize-dkg-assets
Oct 20, 2025
Merged

fix: sanitize emojis#20
Bojan131 merged 1 commit into
feature/vector-dbfrom
fix/sanitize-dkg-assets

Conversation

@Lexpeartha

Copy link
Copy Markdown

No description provided.

@Lexpeartha Lexpeartha self-assigned this Sep 8, 2025
@Lexpeartha Lexpeartha requested a review from Bojan131 September 8, 2025 14:17

@Bojan131 Bojan131 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the hardcoded regex in emoji-strip.ts with the emoji-regex
package. This will keep the codebase cleaner and ensure all current and future Unicode emojis are covered automatically without needing manual updates.

@Lexpeartha

Copy link
Copy Markdown
Author

Please replace the hardcoded regex in emoji-strip.ts with the emoji-regex package. This will keep the codebase cleaner and ensure all current and future Unicode emojis are covered automatically without needing manual updates.

This regex we are using is actually generated from that package. I did not want to add dependency for temporary hotfix, but if you feel strongly against it - I can use the package instead.

@Bojan131

Copy link
Copy Markdown

Please replace the hardcoded regex in emoji-strip.ts with the emoji-regex package. This will keep the codebase cleaner and ensure all current and future Unicode emojis are covered automatically without needing manual updates.

This regex we are using is actually generated from that package. I did not want to add dependency for temporary hotfix, but if you feel strongly against it - I can use the package instead.

Aha okay than, its okay like this

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale due to 30 days of inactivity.
If no further activity occurs within 7 days, it will be closed automatically. Please take action if this pull request is still relevant.

@Bojan131 Bojan131 merged commit b66a2cd into feature/vector-db Oct 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants