Skip to content

test(publisher): adapter-level coverage for V2 chunked StorageACK handler + canonical CG keying (#729 Bug 4) #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
branarakic merged 3 commits into from
May 27, 2026
Merged

test(publisher): adapter-level coverage for V2 chunked StorageACK handler + canonical CG keying (#729 Bug 4) #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db03fc
test(publisher): adapter-level coverage for V2 chunked StorageACK han…
branarakic May 27, 2026
8f76ad6
test(publisher): address Codex review on PR #738 V2 ACK tests
branarakic May 27, 2026
0b1d853
test(publisher): use NUMERIC_CG_ID_B literal instead of '42'+1n
branarakic May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions packages/publisher/src/storage-ack-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,24 @@ export interface StorageACKHandlerConfig {
* normalizer.
*/
normalizeContextGraphIdForChunkStore?: (cgId: string) => string | null;
/**
* Test-only knob to shrink the V2 chunked-ACK local-wait retry
* budget (default 20 retries × 500ms = 10s). The defaults exist so
* the SWM ingest can finish persisting chunks before the ACK
* lookup runs on freshly-subscribed cores; production callers
* MUST NOT override this. Tests that exercise the deterministic
* MISSING_CIPHERTEXT_CHUNKS decline path use it to keep CI fast
* without changing the production behaviour pin.
*
* Codex review on PR #738: the prior MISSING_CHUNKS regression
* burned the full ~10s retry budget on every run. The injection
* point is intentionally narrow — only `maxRetries` and
* `delayMs` are tunable; the loop structure is unchanged.
*/
_v2ChunkLookupRetryPolicyForTests?: {
maxRetries: number;
delayMs: number;
};
}

/**
Expand Down Expand Up @@ -368,8 +386,14 @@ export class StorageACKHandler {
// small devnets that can take a few seconds. Production cores
// that have been hosting the CG for ages will hit the cache on
// the first iteration so the extra budget is free.
const MAX_LOCAL_WAIT_RETRIES = 20;
const LOCAL_WAIT_DELAY_MS = 500;
//
// The optional `_v2ChunkLookupRetryPolicyForTests` config knob
// shrinks this for the MISSING_CIPHERTEXT_CHUNKS regression
// test; production callers leave it undefined and inherit the
// 20×500ms defaults.
const testRetryPolicy = this.config._v2ChunkLookupRetryPolicyForTests;
const MAX_LOCAL_WAIT_RETRIES = testRetryPolicy?.maxRetries ?? 20;
const LOCAL_WAIT_DELAY_MS = testRetryPolicy?.delayMs ?? 500;
const normalizeCgId = this.config.normalizeContextGraphIdForChunkStore;
// Codex review (round 2) on PR #727: explicitly allow the
// normalizer to return null — that means "can't trust a canonical
Expand Down
Loading
Loading