fix: enforce unique receiver identities in signature verification#457
Merged
Conversation
Prevent a single node from faking multi-party attestation by submitting duplicate identity IDs. The new check counts unique identities and reverts if the count falls below minimumRequiredSignatures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Address CI review: early-exit once uniqueCount reaches minimumRequiredSignatures to cap gas on large receiver sets, and add positive tests proving duplicates are accepted when enough unique identities remain. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…arrays from config Single external call to parametersStorage.minimumRequiredSignatures() reused across length check, uniqueness check, and short-circuit. Tests now derive receiver array sizes from ParametersStorage so they stay correct if the config value changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_verifySignatures()forKnowledgeCollection"Insufficient unique receiver identities"only when the number of unique identities falls belowminimumRequiredSignatures— duplicates are tolerated if enough unique identities remainTest plan
🤖 Generated with Claude Code
Note
High Risk
Touches signature-threshold enforcement in a Solidity contract; mistakes here can allow forged multi-party attestation or inadvertently reject valid submissions.
Overview
Prevents meeting
minimumRequiredSignaturesvia duplicated receiveridentityIdsby counting unique identities inKnowledgeCollection._verifySignaturesand reverting when the unique count is below the threshold.Adds unit coverage for the new behavior: all-duplicate receiver lists now revert with
"Insufficient unique receiver identities", while mixed lists with enough unique identities still succeed.Written by Cursor Bugbot for commit bd0f4d2. This will update automatically on new commits. Configure here.