Add TLS encryption#13
Open
mahdi-orbitalize wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
consensus.gowas updated to enable client-side (handled byrafthttpif we provide atransport.TLSInfowhen constructing arafthttp.transport) and server-side (handled by extracting atls.Configfrom thetransport.TLSInfoand passing it to the server at construction plus usingListenAndServeTLSinstead ofListenAndServe)gen-cert.shwas introduced to make certificates (with the number of nodes as a parameter). Note that it's made to work for local setups (i.e. address islocalhostor127.0.0.1). I also provided example certificates to save the trouble of generating them.params.gowas updated to support passing the paths to the TLS certificates as a parameter. It also enforces the use ofHTTPSinstead ofHTTPfor the peers' URLs. Also, more tests were added toparams_test.goto test the new features.start_cluster.shwas created to quickly test a 3-node setup with TLS and easily inspect logs.How I tested it: