Google Ads v24.1#140
Open
Lewis-Clayton wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to Google Ads API v24.1 (google-ads-node
24.1.0-beta.0, google-gax5.0.7), plus a batch of correctness fixes around parsing, field masks, report streams, and the service cache.Breaking change
parse()now returns plain objects for message-typed leaves (e.g.change_event.old_resource) instead of protobuf message instances, and converts all nested int64 values fromLongto JavaScriptnumber. Code reading.low/.highon nested values, calling protobuf methods on nested messages, or relying on protobuf prototypes must use the plain values. Nested int64s above 2^53 lose precision (consistent with the existing top-level behaviour). Seesrc/parser.tsandsrc/parser.spec.ts.Codegen / new surface
ReservationService,YouTubeVideoUploadServiceAppTopCombinationView,CartDataSalesView,VideoEnhancement,YouTubeVideoUploadReservationRequestType,PreviewType) and newExperimentTypevalues (ADOPT_AI_MAX,ADOPT_BROAD_MATCH_KEYWORDS,OPTIMIZE_ASSETS,PMAX_REPLACEMENT_SHOPPING)segments.mobile_device_platformandcustomer_user_access.passkey_enabledFixes
/gregex inscripts/fields.tsdroppedresource_namefor consecutive view resources. Nine pre-existing views (keyword_view,paid_organic_search_term_view,ad_schedule_view,display_keyword_view,hotel_performance_view,location_view,matched_location_interest_view,targeting_expansion_view,travel_activity_group_view) now exposeresource_namein parsed rows.getFieldMask()hardening — throws a descriptiveErroron circular references instead of overflowing the stack; treatsBuffer/Uint8Array/Longvalues as leaves. Update masks built from payloads containingLongvalues no longer emit.low/.high/.unsignedpaths that the API rejected.streamer()now destroys the pipeline, JSON parser, and underlying response stream in afinally, so consumers that break out offor awaitearly don't leak sockets.@isaacs/ttlcachefloor bumped to^1.4.0forcheckAgeOnGet: true(stale entries past TTL no longer returned), andloadServicenow callsget()once to close a TOCTOU race where expired-awaiting-purge resolved toundefined. Eviction callsclose()defensively so a rejected promise or sync throw can't leak the channel.listAccessibleCustomers()— uses a one-shotCustomerServiceClientwithskipCache: trueand closes it infinally, instead of polluting the long-lived service cache.FAILURE_KEYdrift guard — explicit check so a future google-ads-node bump that renames the key fails loudly rather than silently breaking error parsing.