chore(deps): upgrade the OpenZeppelin adapters and UI packages - #416
Merged
Conversation
The adapters went through two majors while this repo stayed on ^2.x: 3.0.0 removed WalletConnect support, and 4.0.0 corrected the package licences to AGPL-3.0. Caret ranges do not cross a major, so the builder kept resolving adapter 2.x -- code that still registers the walletConnect connector, still asks for a WalletConnect projectId, and still declares MIT. - @openzeppelin/adapter-evm ^2.3.0 -> ^4.0.0 - @openzeppelin/adapter-midnight ^2.0.1 -> ^4.0.0 - @openzeppelin/adapter-polkadot ^2.0.2 -> ^3.0.0 (no AGPL major; already AGPL) - @openzeppelin/adapter-solana ^2.0.0 -> ^4.0.0 - @openzeppelin/adapter-stellar ^2.0.2 -> ^4.0.0 - @openzeppelin/adapters-vite ^2.0.0 -> ^11.0.0 The UI packages had to move with them. adapter-evm@4 peer-requires @openzeppelin/ui-types ^3.5.0, while pnpm-workspace.yaml pinned it to exactly 3.3.0, so the first attempt failed 34 tests with: [@openzeppelin/adapter-evm] Incompatible @openzeppelin/ui-types version. Both the app's ranges and the workspace overrides needed bumping -- the overrides pin exact versions and would otherwise force the app's ranges straight back down: - ui-types 3.3.0 -> 3.5.1, ui-utils 3.3.0 -> 4.0.0, ui-components 3.8.0 -> 3.8.2, ui-react 3.3.0 -> 3.3.1, ui-renderer 3.4.0 -> 3.4.1, ui-storage ^1.2.2 -> ^1.2.4 adapters-vite crosses nine majors and ui-utils one. Both are pre-existing drift rather than something this work introduced; the pins had stopped tracking the packages. versions.ts needed no change: #413 already synced the exported-app pins to the same 4.x line, so the builder's own dependencies and its exported apps now agree. Verified: typecheck clean, 47 test files pass (34 were failing before the UI packages were bumped), production build succeeds, lint and format:check clean, `pnpm install --frozen-lockfile` passes, and the dependency licence guard still reports zero @trezor/*, @reown/* and @walletconnect/* entries. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The adapters went through two majors while this repo stayed on
^2.x:Caret ranges don't cross a major, so the builder kept resolving adapter 2.x: code that still registers the
walletConnectconnector, still asks for a WalletConnectprojectId, and still declares MIT.Adapter bumps
@openzeppelin/adapter-evm^2.3.0^4.0.0@openzeppelin/adapter-midnight^2.0.1^4.0.0@openzeppelin/adapter-polkadot^2.0.2^3.0.0@openzeppelin/adapter-solana^2.0.0^4.0.0@openzeppelin/adapter-stellar^2.0.2^4.0.0@openzeppelin/adapters-vite^2.0.0^11.0.0adapter-polkadotstops at 3.0.0 — it didn't take the AGPL major, having already declared AGPL-3.0.The UI packages had to move with them
The first attempt failed 34 tests:
adapter-evm@4peer-requires@openzeppelin/ui-types ^3.5.0, whilepnpm-workspace.yamlpinned it to exactly3.3.0. Both the app's ranges and the workspace overrides needed bumping — the overrides pin exact versions and would otherwise force the app's ranges straight back down:ui-typesui-utilsui-componentsui-reactui-rendererui-storage^1.2.2^1.2.4adapters-vitecrosses nine majors andui-utilsone. Both are pre-existing drift rather than something this work introduced — the pins had simply stopped tracking the packages. That is the part most worth a reviewer's eye.Exported apps
versions.tsneeded no change: #413 already synced the exported-app pins to the same 4.x line. So the builder's own dependencies and its exported apps now agree on the adapter major — the mismatch flagged in #414 is closed.Verification
format:checkcleanpnpm install --frozen-lockfilepasses@trezor/*,@reown/*,@walletconnect/*