Repository navigation
L-11: Bind the admin in the custom example with a co-signing pauser - #125
Open
haseebrabbani wants to merge 1 commit into
Open
haseebrabbani wants to merge 1 commit into
haseebrabbani wants to merge 1 commit into
Conversation
haseebrabbani
requested review from
0xNeshi,
ericnordelo,
igingu and
pepebndc
as code owners
November 18, 2026 13:09
0xNeshi
force-pushed
the
audit-m1-02-l11
branch
from
November 19, 2026 10:37
19d1857 to
b8f6620
Compare
The pauser moves into AppRoles and co-signs MyRules, MyHolding, MyTransferInstruction and MyAllocation; MyHolding_Spend needs its authority too. The admin alone can no longer create a second rules contract, mint or copy a holding, or spend one outside the workflows. Co-signing alone does not close the gap, because the admin chooses the pauser field: it can sign every template naming a pauser it controls. The consumption operations, the allocation pin and the instruction expiry therefore refuse a contract that names a different pauser, so such a registry is a separate token. Document that roles and policy on a rules contract restrict wallets only (HoldingOps, TokenRules, the utils trust boundary), that one TokenRules per configuration is operator practice, and the co-signing pauser's privacy, liveness, coordination and independence costs. Closes #95
0xNeshi
force-pushed
the
audit-m1-02-l11
branch
from
November 19, 2026 12:49
b8f6620 to
1238926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95. Stacked on #116 (L-05); base
audit-m1-02-l05.Changes
pausermoves intoAppRolesand co-signsMyRules,MyHolding,MyTransferInstructionandMyAllocation;MyHolding_Spendalso needs it. The admin alone can no longer create a rules contract, mint or copy a holding, or spend one outside the workflows.pauserfield and can sign a whole registry naming itself.myOps(fund, deliver, return),pinMyAllocationandMyRules_ExpireTransferInstructionsnow refuse contracts naming a different pauser. Without this, such a registry's holding funds a real transfer and its allocation covers a real settlement leg (shown by mutation).HoldingOps,TokenRulesand the utils trust boundary state that roles and policy on a rules contract restrict wallets only. The integration guide calls oneTokenRulesper configuration operator practice. The custom README adds "Binding the admin" with privacy, liveness, coordination and independence costs. No CHANGELOG entry (example and doc comments only).Notes
Allocation_Settleby admin + executors still skips the pause and allowlist. Left to [M1: Audit 2: L-07]: Document creation-time policy and check the pause at delivery in the custom example #85 (policy at delivery); the README says so.actAsparty, so a local admin cannot co-sign genesis with an external pauser. Documented under coordination.settleBatchImpl: forward each authorizer's own context to itsAllocation_Settle#82 inmyOps.