fix hr ceiling missing uneven-motion holds + stale doc cleanup - #55
fix hr ceiling missing uneven-motion holds + stale doc cleanup#55abdulsaheel wants to merge 1 commit into
Conversation
…o docs sessionHrCeiling bailed on the first duration-qualifying window even when its motion average failed the gate, so a real held ceiling with motion concentrated at the edges (quiet middle) never got found. now it keeps extending the window (capped at 4x holdSeconds) until motion actually corroborates before giving up on a start index. also fixed a few stale doc claims: test count was hardcoded at 290 (actual is 624 passed / 6 skipped), the workout family still advertised explicit/ retroactive detection that was deleted, and both README and ALGORITHMS.md still pointed at foundations/ppg_sqi.dart which doesn't exist on main.
Reviewer's GuideFix session HR ceiling detection for efforts whose corroborating motion is concentrated near the edges by extending each duration-qualified window up to a 4x hold-duration cap before rejecting it, while cleaning stale API references and updating documentation test counts. Flow diagram for extended HR ceiling motion corroborationflowchart TD
A[Start candidate index] --> B[Extend window through samples]
B --> C{Duration qualifies?}
C -->|No| B
C -->|Yes| D{Span exceeds 4x holdSeconds?}
D -->|Yes| E[Reject candidate]
D -->|No| F[Compute motion average]
F --> G{Motion meets gate?}
G -->|No| B
G -->|Yes| H{Higher sustained HR than best?}
H -->|Yes| I[Update HrCeiling]
H -->|No| J[Stop this candidate]
I --> J
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning Review limit reachedNext included review available in 40 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
squashed into #59 for one clean review — closing this round. |
sessionHrCeiling was giving up on a start index right after checking the minimal duration-qualifying window's motion average, so a real held ceiling with motion concentrated at the edges (quiet middle) never got found. now it keeps extending the window (capped at 4x holdSeconds) until motion actually corroborates.
also cleaned up a few stale doc claims in README/ALGORITHMS: hardcoded test count (was 290, actually 624 passed / 6 skipped), workout family still mentioned explicit/retroactive detection that's deleted, and both docs still pointed at foundations/ppg_sqi.dart which doesn't exist anymore.
Summary by Sourcery
Improve session heart-rate ceiling detection for uneven-motion efforts and bring project documentation up to date.
Bug Fixes:
Documentation: