Repository navigation
osc: record the host build's commit in run metadata - #305
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run-directory meta.json recorded git_sha from the current working directory, so a bench run from the bringup repo stored that repo's HEAD. A build script now embeds the osc crate's own commit (OSC_HOST_GIT_SHA, "unknown" outside a checkout) and meta.json, the capture pilot envelope and the lut build source string record it as host_git_sha; the old git_sha key is dropped (nothing read it) and envelope.toml still accepts it on load. Test: a_verify_run_leaves_its_recording checks the key against the build constant; toml_round_trips loads an old envelope.
https://claude.ai/code/session_016NV5eybqhfjQPnesWHUCRs