Set airborne condition for jumper sequences#792
Open
mfzl wants to merge 2 commits intoOpenRA:masterfrom
Open
Conversation
Author
@Mailaender thanks for catching this. It was accidental |
Member
|
Can you squash your commits? |
MustaphaTR
requested changes
Jan 3, 2023
Member
There was a problem hiding this comment.
This fixes the crash, but spy just continues to use its own sprites if you try to disguise it as a Rocketeer, which as abcdefg30 pointed out in #786, you could do in the original game.
This seems to be how bodies for rocketeer set up in Romanov's Vengeance and does the job of giving the spies Rocketeer's ground walk anim:
WithInfantryBody:
RequiresCondition: !airborne
WithInfantryBody@Air:
StandSequences: fly
MoveSequence: fly
DefaultAttackSequence: shoot-air
IdleSequences: idle-air
RequiresCondition: airborne
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's already a PR #786 for
flysequence, but that doesn't completely fix the problem as I get the following after the fix.Another option is to define these sequences for
spy, but then it looks really weird and it's a dead give-away.