Repository navigation
Master pull latest - #235
Merged
Merged
Conversation
fix: next button availability in concept pages
dev > master
In Safari/WebKit, enablePersistence's IndexedDB initialization intermittently never settles. Firestore queues every read behind persistence init, so the app hangs forever on the app-wide SuspenseWithPerf loader (Chrome's IndexedDB is unaffected). experimentalForceOwningTab did not cure it. Removes enablePersistence entirely (prod <Firebase> component + Cypress emulator path); keeps experimentalForceLongPolling for real browsers. Verified on a real HTTPS preview channel against production Firestore: reads resolve in ~270ms vs. never settling (0 requests on the wire) with persistence enabled. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ate on logout
After sign-in, Firestore could attach the dashboard's users/{uid}/courses listener
before the freshly-issued ID token reached its connection, yielding an intermittent
permission-denied that reactfire caches and throws to the error boundary (crash; reload
recovers). Adds an AuthReady gate that waits for getIdToken before rendering authed
content (wired via RouteWrapper), fixing the cold-login race.
Same-user re-login in the same tab also reused reactfire's never-evicted global query
observable (keyed by path), re-throwing the stale error consistently. Logout now does a
full reload, clearing that cache and the prime so re-login is a clean cold load.
Verified on a preview channel against prod Firestore across fresh-tab and same-tab
logout/login in Chrome and Safari.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Fix Safari infinite-loading and post-login dashboard crash
Repo was renamed OpenMined/openmined -> OpenMined/courses-app. Updates the user-facing in-app 'file an issue' link (content/links.ts), the README support link, and TODO-comment URLs to the new name. Community discussion links (OpenMined/courses) are intentionally unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… a multi-site monorepo Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Update repo references to OpenMined/courses-app after rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist