fix(ci): name wheel artifacts by platform tag, not runner label - #530
Merged
Merged
Conversation
philomath213
had a problem deploying
to
testpypi
September 7, 2026 02:27 — with
GitHub Actions
Failure
philomath213
had a problem deploying
to
testpypi
September 7, 2026 03:06 — with
GitHub Actions
Failure
youben11
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wheel artifact name used the runner label. Two matrix rows share
ubuntu-24.04, so manylinux and musllinux both uploaded asdist-wheel-<py>-ubuntu-24.04. The uploads succeed. Butdownload-artifactwithmerge-multipleextracts artifacts with the same name over each other, so the publish job ships one platform less and still reports success.TestPyPI
0.3.17.dev6shows the result: 13 files, not 17, and no manylinux wheels. The rehearsal before musllinux (dev4) also had 13 files, but with manylinux. The new platform replaced a platform instead of adding one.matrix.target[1], the platform tag. It is unique for each row, and the job name andCIBW_BUILDalready use itRELEASING.mdfrom 12 to 16. That count is the check which must catch this problemThe matrix gives 16 artifact names, and all 16 are unique. The names stay unique with the
manylinux_aarch64row from #529: 20 names, 20 unique.tests.ymlcannot verify this fix, because it uploads no artifacts. Use a TestPyPI rehearsal. Expect 17 files, andmanylinux_2_28_x86_64must be present.Released versions are correct. v0.3.17 is older than musllinux, so its 12 wheels are complete. Only a release after #528 loses manylinux.