Skip to content

Fix ParamType Name and Id Missmatch #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cornelius-koepp wants to merge 2 commits into
base: v1dev
Choose a base branch
from
Open

Fix ParamType Name and Id Missmatch #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f085e1
Fix(ParamType): Sync Name and Id
cornelius-koepp Apr 24, 2026
489550a
Fix(Partial ParamType): Sync Id for "DfaChoiceStateENUM"
cornelius-koepp May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# (upcoming with new xml version)

* Fix: ParameterType-Names were not in sync with id
* DocText255, DfaInputLogicNumberOptional
* Merged Part: DfaChoiceStateENUM (not included in resulting XML)

# (upcoming)

* Fix #72: Show Startup and do not include "NO_TIMEOUT" in Channel-State Response
Expand Down
2 changes: 1 addition & 1 deletion src/DfaModule.choice_state_numbers.part.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
-->
<Static>
<ParameterTypes>
<ParameterType Id="%AID%_PT-DfaStateENUM.choice_state_numbers.part" Name="DfaChoiceStateENUM">
<ParameterType Id="%AID%_PT-DfaChoiceStateENUM" Name="DfaChoiceStateENUM">
<TypeRestriction Base="Value" SizeInBit="8">
<Enumeration Value="%DfaChoiceStateNumber+64%" Text="%DfaChoiceStateLetter%&gt;" Id="%ENID%" />
</TypeRestriction>
Expand Down
4 changes: 2 additions & 2 deletions src/DfaModule.share.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</TypeRestriction>
</ParameterType>

<ParameterType Id="%AID%_PT-DocText255" Name="DocumentationText255Char">
<ParameterType Id="%AID%_PT-DocText255" Name="DocText255">
<TypeText SizeInBit="2040" />
</ParameterType>

Expand Down Expand Up @@ -120,7 +120,7 @@
<TypeNumber SizeInBit="16" Type="unsignedInt" minInclusive="1" maxInclusive="%LOG_NumChannels%" />
</ParameterType>

<ParameterType Id="%AID%_PT-DfaInputLogicNumberOptional" Name="DfaInputLogicNumber">
<ParameterType Id="%AID%_PT-DfaInputLogicNumberOptional" Name="DfaInputLogicNumberOptional">
<TypeNumber SizeInBit="8" Type="unsignedInt" minInclusive="0" maxInclusive="%LOG_NumChannels%" />
</ParameterType>

Expand Down
Loading