fix(4-20mA): correct change-detection logic in processInput_4_20mA - #2
Open
martinhoefling wants to merge 1 commit into
Open
fix(4-20mA): correct change-detection logic in processInput_4_20mA#2martinhoefling wants to merge 1 commit into
martinhoefling wants to merge 1 commit into
Conversation
- Use CUR_CHSensorTypes2 (physical sensor type) instead of CUR_CHSensorType2 (input mode) when selecting the relative-change threshold. The mode value 0-20mA (2) collided with the SensorType_humidity case (2), forcing a 100% relative threshold and effectively disabling relative-change sending on 0-20mA inputs. - Replace integer abs() with fabsf() in the absolute and relative change checks so sub-1.0 differences are no longer truncated. - Guard calculateSensorValueLinearFunction2 against equal 4mA/20mA scaling points (e.g. both left unconfigured), which previously caused a division by zero and a NaN value being stored/sent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use CUR_CHSensorTypes2 (physical sensor type) instead of CUR_CHSensorType2 (input mode) when selecting the relative-change threshold. The mode value 0-20mA (2) collided with the SensorType_humidity case (2), forcing a 100% relative threshold and effectively disabling relative-change sending on 0-20mA inputs.
Replace integer abs() with fabsf() in the absolute and relative change checks so sub-1.0 differences are no longer truncated.
Guard calculateSensorValueLinearFunction2 against equal 4mA/20mA scaling points (e.g. both left unconfigured), which previously caused a division by zero and a NaN value being stored/sent.