ci: read integration test default models from checked-out branch#3109
Closed
ci: read integration test default models from checked-out branch#3109
Conversation
The integration-runner workflow uses pull_request_target, which always evaluates workflow-level env vars from the default branch (main). When a release branch updates DEFAULT_MODEL_IDS before those changes are merged to main, the integration tests still run with the old model set. Move the default model list into DEFAULT_INTEGRATION_MODEL_IDS in resolve_model_config.py. Because the setup-matrix step already checks out the PR branch, the Python constant is read from the correct branch regardless of what main contains. Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
Collaborator
Author
|
Closing — this was over-engineered. The workflow env var is the right place for the default model list. The original issue was a one-time timing problem (label applied before the model update was merged to main), not a systemic issue that needs a code fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
integration-runner.ymlworkflow usespull_request_target, which always evaluates workflow-levelenv:vars from the default branch (main). When a release branch updates the default model list before those changes are merged to main, the integration tests still run with the old model set.This is what happened with the v1.21.0 release PR #3103: the
integration-testlabel was applied before the model update PR #3102 was merged to main, so CI ran againstkimi-k2-thinkinganddeepseek-v3.2-reasonerinstead of the intendedkimi-k2.6anddeepseek-v4-flash.Fix
Move the default model list from a workflow-level
env:var (DEFAULT_MODEL_IDS) into a Python constant (DEFAULT_INTEGRATION_MODEL_IDS) in.github/run-eval/resolve_model_config.py.Since the
setup-matrixstep already checks out the PR branch before runningresolve_model_config.py, the Python constant is always read from the correct branch — regardless of what main contains.Changes
.github/run-eval/resolve_model_config.pyDEFAULT_INTEGRATION_MODEL_IDSlist.github/workflows/integration-runner.ymlDEFAULT_MODEL_IDSenv var; read defaults from Pythontests/cross/test_resolve_model_config.pyMODELSHow to update default models going forward
Edit the
DEFAULT_INTEGRATION_MODEL_IDSlist in.github/run-eval/resolve_model_config.py. Changes take effect immediately on any branch — no need to wait for main to be updated.This PR was created by an AI agent (OpenHands) on behalf of the user.
@xingyaoww can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22-slimgolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:d220ba0-pythonRun
All tags pushed for this build
About Multi-Architecture Support
d220ba0-python) is a multi-arch manifest supporting both amd64 and arm64d220ba0-python-amd64) are also available if needed