Add task_type column for tasks table#46
Open
dwhswenson wants to merge 1 commit into
Open
Conversation
This only adds the column to the table; it does not add anything to support using that when checking out a task (out of scope for this PR). Also adds a convenience `task_row` in testing, which makes it easier to test with optional columns in rows. Assisted-by: Codex.app:GPT-5.4
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 91.44% 99.03% +7.59%
==========================================
Files 7 6 -1
Lines 526 519 -7
==========================================
+ Hits 481 514 +33
+ Misses 45 5 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atravitz
approved these changes
May 29, 2026
atravitz
left a comment
atravitz
left a comment
Contributor
There was a problem hiding this comment.
one optional addition, otherwise lgtm!
|
|
||
| def test_add_task_network_unknown_task_type_key(self, fresh_db, | ||
| diamond_taskid_network): | ||
| with pytest.raises(ValueError, match="unknown tasks"): |
Contributor
There was a problem hiding this comment.
Suggested change
| with pytest.raises(ValueError, match="unknown tasks"): | |
| with pytest.raises(ValueError, match=r"unknown tasks: \[\'missing\'\]"): |
Maybe unnecessary, but I like to make sure it's reporting the correct thing this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #41.
This only adds the column to the table; it does not add anything to support using that when checking out a task (out of scope for this PR).
Also adds a convenience
task_rowin testing, which makes it easier to test with optional columns in rows.Assisted-by: Codex.app:GPT-5.4