Fix false positive tests in ksp-codegen by correcting assertContainAll logic#1573
Open
justdeok wants to merge 1 commit intoOpenFeign:masterfrom
Open
Fix false positive tests in ksp-codegen by correcting assertContainAll logic#1573justdeok wants to merge 1 commit intoOpenFeign:masterfrom
justdeok wants to merge 1 commit intoOpenFeign:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 813 838 +25
Lines 31466 31795 +329
Branches 3614 3622 +8
=======================================
- Misses 31466 31795 +329
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a logic error in
assertContainAllwhere it was validating the expected string against itself instead of the actual output.Key Changes
assertContainAllfromothertothis.