refactor: Delete isFinal , isStatic to support recored

[thdwoqor]

#105

val modifiers = field.getModifiers();
      if (isFinal(modifiers) || isStatic(modifiers)) {
        continue;
      }

This code causes the recorded dto to not work correctly
More precisely, the @FormProperty annotation does not work.

"Pojo" does not Limit field.
You also don't need to Limit the field of 'DTO'

---

Example

@FeignClient(url="https://oauth2.googleapis.com", value = "GoogleAuthApi")
public interface GoogleAccessTokenClient {

    @PostMapping(
            value = "/token",
            consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE,
            produces = MediaType.APPLICATION_JSON_VALUE
    )
    GoogleAccessTokenResponse getGoogleToken(
            GoogleAccessTokenRequest request
    );
}

@Data
public class GoogleAccessTokenRequest {

    @FormProperty("client_id")
    private String clientId;
    @FormProperty("client_secret")
    private String clientSecret;
    private String code;
    @FormProperty("redirect_uri")
    private String redirectUri;
    @FormProperty("grant_type")
    private String grantType;
}

Code where the @FormProperty annotation works correctly

public record GoogleAccessTokenRequest(

        @FormProperty("client_id")
        String clientId,
        @FormProperty("client_secret")
        String clientSecret,
        String code,
        @FormProperty("redirect_uri")
        String redirectUri,
        @FormProperty("grant_type")
        String grantType
) {
}

Code where @FormProperty annotations don't work correctly

[OlgaMaciaszek]

Thanks, I'm not a maintainer in the OpenFeign org, only in Spring Cloud OpenFeign. CC @velo .

[debcode-me]

Just out of curiosity, do we need to update the test cases?
And can someone also shed some light of the use cases for which these isStatic & isFinal filters were added.

[robinmayerhofer]

These isStatic and isFinal filters also affect data classes with vals in Kotlin - they simply won't be serialized.

[alexandrklimov]

Does anybody know, there is any plans to merge this PR?