Skip to content

Conversation

@GibranHL0
Copy link

@GibranHL0 GibranHL0 commented Jul 13, 2021

PR Created

⚠️ The PR goal is to solve issue #306

This PR is a work in progress, its creation is to show the current development of the issue. I'll make changes.

Things to be done

  • Create Widget, DCC and DC6 structures
  • Create WidgetState, DCCState and DC6State structures
  • Write documentation
  • Create Widget interfaces
  • Rewrite encode
  • Rewrite decode
  • Rewrite initState
  • Rewrite setState
  • Rewrite runPlayer
  • Rewrite recalculateTiledViewWidth
  • Rewrite recalculateTiledViewHeight
  • Rewrite createImage

@gravestench gravestench linked an issue Jul 13, 2021 that may be closed by this pull request
@gravestench gravestench marked this pull request as draft July 13, 2021 16:29
@gravestench
Copy link
Contributor

I don't think that rewriting the encode/decode for the dcc and dc6 format should be part of this PR. those are two very large changes, each deserving their own PR.

@GibranHL0
Copy link
Author

Sure then, I'll revert those changes

@gravestench
Copy link
Contributor

What's the status on this?

@GibranHL0
Copy link
Author

I'm doing great, I'm working with a single property in an embedded structure that the linter detected as not used even if it was, so I'm finding a new way to re-write the structure.

@gucio321
Copy link
Contributor

gucio321 commented Aug 9, 2021

I'm working with a single property in an embedded structure that the linter detected as not used even if it was,

btw, it is a known bug with unexported struct fields. you can just nolint it: https://golangci-lint.run/usage/false-positives/#nolint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge dccwidget and dc6widget

3 participants