-
-
Notifications
You must be signed in to change notification settings - Fork 110
Add option to disable bit rate switching for socket can #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1d0c969 to
f23e13d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Could you please bump the minor version and drop a line in the changelog? You will find details in CONTRIBUTING.md I will merge it right away.
Out of curiosity, did you code this by hand or was it done by a language model?
When running in CAN-FD mode, but with same nominal and data baudrate, BRS bit has to remain at zero. That indicates that there is no bitrate switch happening for data and data is transmitted at same speed.
f23e13d to
214db6a
Compare
Done.
I'm using some language models in my workflow, but in this particular instance it was done by me. There really is not much coding going on in this case and it seems easier to write few lines than try to explain what you want to language model. |
|
Sorry, it is important that we bump the minor version as I mentioned and not the patch version. The minor version ought to be incremented for new features. Can you please update that?
While reading the code it felt like it was done by an LLM, so I decided to ask ;) |
214db6a to
de1add0
Compare
Done, |
When running in CAN-FD mode, but with same nominal and data baudrate (just 64B data payload, but without transmitting data faster), BRS bit has to remain at zero. That indicates that there is no bitrate switch happening for data and data is transmitted at same speed.
If I send message with BRS=1, even with data & nominal speed configured the same, I get framing errors on the bus. Even single message like this kills my whole bus.
This introduces option to do that via uavcan.udp.disable_brs set to true, or determines this automatically when uavcan.udp.bitrate indicates same bitrate for header & data.