DRAFT F Prime v4.2.2 upgrade#398
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| dictionary constant SpacecraftId = 0x0044 | ||
|
|
||
| @ Fixed size of CCSDS TM frames | ||
| dictionary constant TmFrameFixedSize = 248 # Needs to be at least COM_BUFFER_MAX_SIZE + (2 * SpacePacketHeaderSize) + 1 |
There was a problem hiding this comment.
I think this change is not correct. Isn't this a radio limitation? I remember something about this when working on the CircuitPython stuff. Need radio integration tests.
There was a problem hiding this comment.
Yes this is a limitation of the max packet size of the radio. If I recall correctly the radio module has a 4 byte header and then the Zephyr Radio driver has another 4 byte header leaving us with 248 (256 - 4 -4 = 248) to use for F Prime.
DRAFT. Waiting for upstream update of fprime-extras.
Pull Request Title (e.g., Feature: Add user authentication)
Description
Related Issues/Tickets
How Has This Been Tested?
Screenshots / Recordings (if applicable)
Checklist
Further Notes / Considerations