Skip to content

DRAFT F Prime v4.2.2 upgrade#398

Draft
nateinaction wants to merge 6 commits into
mainfrom
fprime-v4.2.2
Draft

DRAFT F Prime v4.2.2 upgrade#398
nateinaction wants to merge 6 commits into
mainfrom
fprime-v4.2.2

Conversation

@nateinaction
Copy link
Copy Markdown
Collaborator

@nateinaction nateinaction commented May 18, 2026

DRAFT. Waiting for upstream update of fprime-extras.

Pull Request Title (e.g., Feature: Add user authentication)

Description

Related Issues/Tickets

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Z Tests
  • Manual testing (describe steps)

Screenshots / Recordings (if applicable)

Checklist

  • Written detailed sdd with requirements, channels, ports, commands, telemetry defined and correctly formatted and spelled
  • Have written relevant integration tests and have documented them in the sdd
  • Have done a code review with
  • Have tested this PR on every supported board with correct board definitions

Further Notes / Considerations

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6a899adc-6a4f-4280-b31e-5735b6178ca5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

dictionary constant SpacecraftId = 0x0044

@ Fixed size of CCSDS TM frames
dictionary constant TmFrameFixedSize = 248 # Needs to be at least COM_BUFFER_MAX_SIZE + (2 * SpacePacketHeaderSize) + 1
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is not correct. Isn't this a radio limitation? I remember something about this when working on the CircuitPython stuff. Need radio integration tests.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a limitation of the max packet size of the radio. If I recall correctly the radio module has a 4 byte header and then the Zephyr Radio driver has another 4 byte header leaving us with 248 (256 - 4 -4 = 248) to use for F Prime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants