Regenerate types automatically#86
Draft
martinRenou wants to merge 6 commits intoOpen-EO:masterfrom
Draft
Conversation
martinRenou
commented
Apr 16, 2026
Contributor
Author
|
I was able to make eslint and TypeScript happy, the generated types are now correct. But now jsdocs complains... I'll pause this now. If someone who knows jsdocs more than I do can help that would be great! |
m-mohr
reviewed
Apr 17, 2026
| * | ||
| * @returns {Array.<object.<string,*>>} | ||
| * | ||
| * @returns {Array.<Record.<string,*>>} |
Member
There was a problem hiding this comment.
Just one note right at the beginning:
This is a JavaScript codebase. Using "Record" in the JS documentation would not be correct as "Record" is not specificed/available in JavaScript.
Whatever creates the Typescript declaration has to convert this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #70
Still in draft. I need to test this properly.
For the reviewer, it's easier to review with hiding whitespaces changes https://github.com/Open-EO/openeo-js-client/pull/86/changes?w=1