fix(validation): lint workflows by explicit path - #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the trusted final-state validator so that actionlint can validate workflow files from the isolated snapshot.
Problem
The validator intentionally copies the candidate repository without its
.gitdirectory. However, actionlint was invoked without explicit workflow paths and therefore attempted to discover a Git repository from/repo. This caused the final validation to fail with:no project was found in any parent directories of "/repo"Changes
actionlint_command(snapshot)to construct the isolated Docker command..ymland.yamlfiles under.github/workflows..gitmount..gitis not mounted.Validation
python -m pytest -q scripts/tests/test_pr_automation.py— 96 passed.python -m pytest -q scripts/tests— 525 passed.git diff --check— passed.Docker is not installed locally, so the actionlint container was not run on the developer machine. The GitHub Actions validation will execute it in the intended containerized environment.