chore: Restrict test coverage just for the lines of code changed#2527
Merged
abdulraqeeb33 merged 3 commits intomainfrom Jan 26, 2026
Merged
chore: Restrict test coverage just for the lines of code changed#2527abdulraqeeb33 merged 3 commits intomainfrom
abdulraqeeb33 merged 3 commits intomainfrom
Conversation
added 2 commits
January 23, 2026 10:11
abdulraqeeb33
commented
Jan 23, 2026
| } | ||
|
|
||
| private fun initEssentials(context: Context) { | ||
| for (i in 0..10) { |
Contributor
Author
There was a problem hiding this comment.
Added dummy code, i will get rid of it after testing.
abdulraqeeb33
changed the title
Contributor
📊 Diff Coverage Report✓ Coverage check passed (no source files changed) |
jinliu9508
reviewed
Jan 23, 2026
| @@ -141,6 +242,9 @@ for changed_file in changed_files: | |||
| filename = match.group(3) | |||
| package_name = package_path.replace('/', '/') | |||
Contributor
There was a problem hiding this comment.
Not in the change but it looks like this line doesn't do anything
jinliu9508
approved these changes
Jan 23, 2026
Contributor
jinliu9508
left a comment
jinliu9508
left a comment
There was a problem hiding this comment.
Looks good to me. Make sure to remove the dummy code in OneSignalImp.kt
Removed debug print statements from initEssentials method.
jinliu9508
pushed a commit
that referenced
this pull request
Jan 27, 2026
Co-authored-by: AR Abdul Azeez <abdul@onesignal.com>
jinliu9508
pushed a commit
that referenced
this pull request
Jan 27, 2026
Co-authored-by: AR Abdul Azeez <abdul@onesignal.com>
jinliu9508
pushed a commit
that referenced
this pull request
Jan 27, 2026
Co-authored-by: AR Abdul Azeez <abdul@onesignal.com>
nan-li
pushed a commit
that referenced
this pull request
Jan 27, 2026
Co-authored-by: AR Abdul Azeez <abdul@onesignal.com>
jinliu9508
pushed a commit
that referenced
this pull request
Jan 27, 2026
Co-authored-by: AR Abdul Azeez <abdul@onesignal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Restrict test coverage just for the lines of code changed
Details
Motivation
Earlier the file that was touched was entirely checked for test coverage. We just need to check the lines added/modified if it has test coverage in place.
Scope
Test Coverage Script
Testing
Unit testing
Added some code and tried to test it out.
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is