Skip to content

Diagram: Simple Typo Corrections #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex-ppg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Diagram: Simple Typo Corrections #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions simple_token_bridge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ sequenceDiagram
actor O as Bridge Operator
O->>V: Register Trusted Auditor Key
U->>+B: Register Token with Audit
Note over B,V: Veras much as possibleify that the audit valid for the token<br>and verify the signature
Note over B,V: Verify as much as possible that the audit is valid for the token<br>and verify the signature
Copy link
Copy Markdown
Member

@rmeissner rmeissner Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "as much as possible" was a copy paste error and I would remove it.

B->>+V: submitAudit(SignedAuditSummary audit, address token)
V-->>V: Check that the audit is from trusted auditor
V-->>V: Check that the audit is from a trusted auditor
V-->>-B: bool verified
Note over B,V: Check that ERC-1155 is supported
B->>+V: verifyStandardCheck(uint ercNum, address token)
V-->>V: Lookup supported ERCs on the audit
V-->>-B: bool supported
B-->-U: Registration Response
Note over B,V: Enable the token for bridging
Note over B,V: Authorize the token for bridging
O->>B: Activate Token
U->>B: Bridge Token

Expand All @@ -40,4 +40,4 @@ With this the user (or token owner) can trigger the registration flow (2). There

With the checks being done it is still recommended to have some manual check in place by the operator to activate a token for bridging (10). This step could be omitted if there is a strong trust in the auditor or if an ERC provides strong compatibility guarantees.

Once the token is available on the bridge the users can start using it (11).
Once the token is available on the bridge the users can start using it (11).