flush_group optimization#111
Open
nickchomey wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves group flushing behavior in the SQLite object-cache drop-in by making APCu eviction more targeted and simplifying the in-memory group flush logic.
Changes:
- Add an optional
$group_prefixparameter toapcu_clear_cache()to support clearing a subset of APCu entries. - Update
flush_group()to clear only the relevant APCu entries and remove a redundant “collect then unset” loop. - Stop resetting
$this->not_in_persistent_cacheat the end offlush_group().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
copilot made good points about the double loop. i reverted that change, but some of the changes still valid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed redundant loop and unnecessary variable.
added optional capability to only clear a group from apcu, rather than whole thing
dont wipe
$this->not_in_persistent_cacheat end