Skip to content

Added Haptics, Articulated Hands and Physical Driving options - #80

Merged
Okabintaro merged 3 commits into
masterfrom
Physical-Driving
Dec 21, 2023
Merged

Okabintaro merged 3 commits into
masterfrom
Physical-Driving

Conversation

@jbusfield

@jbusfield jbusfield commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

These updates are working for the original Subnautica but could use some polish. I will be away from the computer until early November so I'll leave it up to you if you want to make a release before then.

@Okabintaro

Copy link
Copy Markdown
Owner

Thanks a lot!
You are doing such good work. I am bad at promising things but I will try to merge, polish and release this next week.

@Okabintaro

Copy link
Copy Markdown
Owner

Hello, I want to merge this today, but am confused. Should I merge both of your PRs or just #76?
It seems like have updated that one the most.

@jbusfield

Copy link
Copy Markdown
Collaborator Author

PR #76 is for the BZ mod so it will be applied to your Below Zero branch.
This PR #80 is for the master branch and will update the original mod.
You can merge both of them but I am finishing up some additional fixes for PR #80 so if you want to hold off merging until a little later today then the release should be a little more solid.

… intro to add back fire. Fixed VR centering in vehicles. Fixed snap turning. Updated Physical Piloting to share codebase with BZ
@jbusfield

Copy link
Copy Markdown
Collaborator Author

Ok, my changes are checked in and ready to merge.

@Okabintaro Okabintaro left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Left a couple of comments, but looks good so far.

|| button == GameInput.Button.Slot5
|| button == GameInput.Button.AutoMove;
|| button == GameInput.Button.AutoMove
|| button.ToString() == "45" || button.ToString() == "46";

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those buttons? Could you please add a comment?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive been trying to get the newest Nitrox working with Submersed Vr and Nitrox added mappings for those two things which was causing constant errors to be thrown. So I was just bypassing those errors with this code.


namespace SubmersedVR
{
class ParticleFX

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, could you add a comment what you tried to do here?
I guess you tried to remove the obvious bill boarding that can happen in unity when you roll the head?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some code from the VREnhancments guys https://github.com/IWhoI/SubnauticaVREnhancements/blob/master/VREnhancements/ParticleFX.cs and I was wondering if it added any benefit. I tried it and it didnt seem to help anything but left the code there in case you had any insight into what they were trying to do.

Comment on lines +176 to +183
//This does 3 things
//1
//While piloting vehicles, the player's head camera gets locked into position when using XRSettings.enabled = true
//While on the hoverbike we dont want to be locked in because we want to eliminate the yaw and pitch to reduce nausea
//2
//Disable the last XRSettings.enabled branch by replacing it with false
//3
//Enable Player Snap Turning

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments! Maybe I will try doing a transpiler. They can be quite powerfull, but hard to learn.

@profplum700

Copy link
Copy Markdown

Is this going to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants