Added Haptics, Articulated Hands and Physical Driving options - #80
Conversation
|
Thanks a lot! |
|
Hello, I want to merge this today, but am confused. Should I merge both of your PRs or just #76? |
|
PR #76 is for the BZ mod so it will be applied to your Below Zero branch. |
… intro to add back fire. Fixed VR centering in vehicles. Fixed snap turning. Updated Physical Piloting to share codebase with BZ
|
Ok, my changes are checked in and ready to merge. |
Okabintaro
left a comment
There was a problem hiding this comment.
Thanks a lot! Left a couple of comments, but looks good so far.
| || button == GameInput.Button.Slot5 | ||
| || button == GameInput.Button.AutoMove; | ||
| || button == GameInput.Button.AutoMove | ||
| || button.ToString() == "45" || button.ToString() == "46"; |
There was a problem hiding this comment.
What are those buttons? Could you please add a comment?
There was a problem hiding this comment.
Ive been trying to get the newest Nitrox working with Submersed Vr and Nitrox added mappings for those two things which was causing constant errors to be thrown. So I was just bypassing those errors with this code.
|
|
||
| namespace SubmersedVR | ||
| { | ||
| class ParticleFX |
There was a problem hiding this comment.
Hm, could you add a comment what you tried to do here?
I guess you tried to remove the obvious bill boarding that can happen in unity when you roll the head?
There was a problem hiding this comment.
I found some code from the VREnhancments guys https://github.com/IWhoI/SubnauticaVREnhancements/blob/master/VREnhancements/ParticleFX.cs and I was wondering if it added any benefit. I tried it and it didnt seem to help anything but left the code there in case you had any insight into what they were trying to do.
| //This does 3 things | ||
| //1 | ||
| //While piloting vehicles, the player's head camera gets locked into position when using XRSettings.enabled = true | ||
| //While on the hoverbike we dont want to be locked in because we want to eliminate the yaw and pitch to reduce nausea | ||
| //2 | ||
| //Disable the last XRSettings.enabled branch by replacing it with false | ||
| //3 | ||
| //Enable Player Snap Turning |
There was a problem hiding this comment.
Thanks for the comments! Maybe I will try doing a transpiler. They can be quite powerfull, but hard to learn.
|
Is this going to be released? |
These updates are working for the original Subnautica but could use some polish. I will be away from the computer until early November so I'll leave it up to you if you want to make a release before then.