Skip to content

fix(dataposter): fail fast on invalid root CA PEM#4207

Closed
maximevtush wants to merge 1 commit intoOffchainLabs:masterfrom
maximevtush:patch-7
Closed

fix(dataposter): fail fast on invalid root CA PEM#4207
maximevtush wants to merge 1 commit intoOffchainLabs:masterfrom
maximevtush:patch-7

Conversation

@maximevtush
Copy link
Copy Markdown
Contributor

Adds validation of AppendCertsFromPEM return value when loading external signer root CA.
Previously, an empty or malformed PEM file would silently result in an empty CA pool, causing obscure TLS handshake failures later.

@joshuacolvin0 joshuacolvin0 added the trivial Adding this tag auto-closes trivial PRs politely. label Jan 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution. However, this PR has been automatically closed because it was labeled as trivial. As stated in our CONTRIBUTING.md:


Important

Please, do not send pull requests for trivial changes; these will be rejected.
These types of pull requests incur a cost to reviewers and do not provide much value to the project.
If you are unsure, please open an issue first to discuss the change.
Here are some examples of trivial PRs that will most-likely be rejected:

  • Fixing typos
  • AI-generated code
  • Refactors that don't improve usability

We appreciate meaningful contributions!

@github-actions github-actions Bot closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trivial Adding this tag auto-closes trivial PRs politely.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants