wxGUI: Fixes UTM hemisphere selection in location wizard #6824
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5467
Problem Description
When creating a UTM location using "Define custom CRS" method and selecting "No" for "Southern Hemisphere?", the wizard incorrectly adds the
+southparameter to the PROJ.4 definition, resulting in a southern hemisphere projection instead of northern.Root Cause
Line 905 in
gui/wxpython/location_wizard/wizard.py:if param["value"] is False:The code used
is Falseto check the parameter value, butwx.Choicewidget returns integer0for "No" selection, not booleanFalse. Theisoperator checks object identity, not value equality, so the condition fails and the+southparameter gets added incorrectly.Solution
Changed the condition to:
if param["value"] == 0 or param["value"] is False:Testing
Before Fix
After Fix