Skip to content

HYRAX-1940 - Initial XML Schema for the DMR++#22

Merged
jgallagher59701 merged 26 commits intomainfrom
jhrg/HYRAX-1940-dmrpp-doc
Mar 23, 2026
Merged

HYRAX-1940 - Initial XML Schema for the DMR++#22
jgallagher59701 merged 26 commits intomainfrom
jhrg/HYRAX-1940-dmrpp-doc

Conversation

@jgallagher59701
Copy link
Copy Markdown
Member

Added the initial version of the DMR++ documentation.

This includes the XML Schema for the dmrpp namespace elements.

@Mikejmnez
Copy link
Copy Markdown
Collaborator

This is starting to look pretty nice! Is there a way to combine dap4 schema and dmrpp schema? Say for validation tests.

@jgallagher59701 jgallagher59701 marked this pull request as ready for review March 23, 2026 15:34
@jgallagher59701
Copy link
Copy Markdown
Member Author

For this PR, the most important documents are in the xml-schema subdirectory. The XML schema is in dmrpp.xsd and a narrative description of the xml elements and attributes is in dmrpp-schema-narrative.adoc.

Copy link
Copy Markdown
Collaborator

@Mikejmnez Mikejmnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread retired/xml-schema/DMRPP-doc-ky.docx
Comment thread xml-schema/dmrpp.xsd Outdated
version="1.0">

<!-- Is this namespace OK: xmlns:dmrpp="http://opendap.org/ns/dmrpp/1.0#" -->

Copy link
Copy Markdown
Collaborator

@Mikejmnez Mikejmnez Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may need to add <xs:import namespace="http://www.w3.org/XML/1998/namespace"/> somewhere. In here https://github.com/OPENDAP/xml/blob/master/dap4/dap4.xsd Line38, it states it is required. Perhaps not an issue now but at some point we will need to add validation tests just the same way we did for the dap4 xsd

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this import is for the xml:base attribute. The comment about the namespace is codex asking me if the namespace http://opendap.org/ns/dmrpp/1.0# is an ok name.

Regardless, validation is a separate task. We can make a ticket for that and work that, but I'm more interested in the narrative correct.

Comment thread xml-schema/dmrpp.xsd Outdated
<!-- How fixed-length strings are padded -->
<xs:simpleType name="PadKind">
<xs:restriction base="xs:string">
<xs:enumeration value="null" />
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these options have "null_pad", "space_pad", and "zero_pad"? I think I saw an example DMR++ that add a "null_pad" value

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Good catch!

@jgallagher59701
Copy link
Copy Markdown
Member Author

I'll add the enumeration values and a ticket about validation. Then merge.

@jgallagher59701 jgallagher59701 merged commit 4b33f98 into main Mar 23, 2026
1 check passed
@jgallagher59701 jgallagher59701 deleted the jhrg/HYRAX-1940-dmrpp-doc branch March 23, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants