-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(colors): Replaces legacy colors with ui-next colors #5351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dan-rukas
wants to merge
27
commits into
OHIF:master
Choose a base branch
from
dan-rukas:fix/replace-legacy-colors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+294
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Changed to primary
DateRange.tsx still includes inputfield-main
Uses foreground at different opacities
sedghi
approved these changes
Sep 17, 2025
Member
|
Member
Author
|
New changes to this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Updated legacy color variables in the App and ui-next components to use current ui-next colors. Replaced 11 legacy variables with current ui-next color system tokens. Additionally, generic colors (e.g., white, blue-500) were replaced with semantic equivalents. Remaining legacy colors with no direct replacements were manually evaluated and replaced on a case-by-case basis.
Migration Guide: Added https://docs.ohif.org/migration-guide/3p11-to-3p12/colors documentation with color mapping reference tables.
Changes & Results
Color Variable Migration: Legacy to ui-next Mapping
bkg-lowbackgroundcommon-brightforeground(various)primary-lighthighlightinputfield-maininputsecondary-lightinputprimary-darkmutedbkg-medmutedaqua-palemuted-foregroundsecondary-darkpopoverprimary-activeprimaryactions-primaryprimarysecondary-mainprimary-maincommon-darkcustomblueEmpty cells indicate legacy variables that were manually replaced (details below)
Generic Color Migrations
whiteforegroundblue-*(e.g.,blue-500)primaryorhighlightgray-*(e.g.,gray-800)mutedorpopoverColors replaced with new colors (not direct replacements)
These legacy variables do not map directly to ui-next color tokens and were evaluated and updated individually based on their use and context.
secondary-mainbg-primary/20for row hoversDropdowncomponentDropdowncomponentprimary-mainprimaryprimaryprimaryButtoncustomblueTabscomponentStudy list related files that will continue to use legacy colors until Study list redesign
Worklist.tsx:
Testing
Some limited testing for specific replacements. Not every replacement was tested since these are direct color replacements (or close to direct).
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment