Introduced ETag annotations to support content caching from browser.#2507
Merged
Conversation
chrisknoll
force-pushed
the
upgrade/performance-etag
branch
from
5ee2efc to
62cff23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an opt-in annotation 'UseEtag' which will set the headers in the response to allow browsers to cache responses. The cohort definition list and concept set list can be very large (6-10MB in our enviornment) and so being able to cache that from across the network is a win.
Note to self: this should have been a sandbox project, however I did provide detailed information on the design in the /articles/ETag_HOWTO.md.