Skip to content

fix: accept lifecycle hyperparameter generators#668

Merged
egillax merged 2 commits into
developfrom
fix-665-generator-object
Jun 17, 2026
Merged

fix: accept lifecycle hyperparameter generators#668
egillax merged 2 commits into
developfrom
fix-665-generator-object

Conversation

@egillax

@egillax egillax commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • allow createHyperparameterSettings() to accept lifecycle generator objects with initialize() and getNext()
  • keep function generators supported and document both generator contracts explicitly
  • add regression coverage for generator objects passed through the constructor

Fixes #665

Testing

  • Rscript -e 'devtools::test(filter = "hyperparameterSettings")'

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (aee14bf) to head (fdeb5a4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #668   +/-   ##
========================================
  Coverage    89.73%   89.74%           
========================================
  Files           49       49           
  Lines        13691    13704   +13     
========================================
+ Hits         12286    12299   +13     
  Misses        1405     1405           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@egillax egillax merged commit ae673c4 into develop Jun 17, 2026
10 checks passed
@egillax egillax deleted the fix-665-generator-object branch June 17, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant