Fix dependency warnings#2703
Open
csafreen wants to merge 2 commits into
Open
Conversation
csafreen
requested review from
SantanM,
brandantck,
p-hoffmann and
suwarnoong
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a couple of flow utilities to reduce warnings and improve runtime behavior, mainly by simplifying how Liquibase connection parameters are built and tightening snapshot-config detection in the cache creation flow.
Changes:
- Refactors Liquibase CLI parameter construction (removes defaults-file generation, passes URL/password directly; improves error fallback message).
- Suppresses chained
CalledProcessErrorcontext when raisingRuntimeErrorfrom Liquibase execution. - Tightens
snapshot_copy_configdetection so “empty” configs don’t block results-cache creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/flows/data_management/data_management_plugin/liquibase.py | Refactors Liquibase invocation parameters and error handling/output parsing. |
| plugins/flows/base/create_cachedb_file_plugin/flow.py | Improves snapshot config presence detection to avoid treating empty configs as configured. |
Comment on lines
+93
to
99
| f"--url={connection_base_url}{connection_properties}", | ||
| f"--password={admin_password}", | ||
| ] | ||
|
|
||
| if self.tenant_configs.authMode != AuthMode.JWT: | ||
| params.append(f"--username={admin_user}") | ||
|
|
Collaborator
There was a problem hiding this comment.
Please solve the comment here
Comment on lines
91
to
95
| f"--defaultSchemaName={self.schema_name}", | ||
| f"--liquibaseSchemaName={self.schema_name}", | ||
| f"--defaults-file={liquibase_properties}" | ||
| f"--url={connection_base_url}{connection_properties}", | ||
| f"--password={admin_password}", | ||
| ] |
Zhimin-arya
reviewed
Jun 18, 2026
Comment on lines
+93
to
99
| f"--url={connection_base_url}{connection_properties}", | ||
| f"--password={admin_password}", | ||
| ] | ||
|
|
||
| if self.tenant_configs.authMode != AuthMode.JWT: | ||
| params.append(f"--username={admin_user}") | ||
|
|
Collaborator
There was a problem hiding this comment.
Please solve the comment here
|
|
||
| # Temporarily create liquibase.properties for sensitive values | ||
| # Won't be logged in traceback | ||
| with open(liquibase_properties, 'w') as file: |
Collaborator
There was a problem hiding this comment.
the liquibase.properties is to prevent leaking credentials, why remove it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes 2 things
Jobspage in the UI then snapshot config is notNone, it has attributes withNulland the result schema wouldn't be created.Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)