Fix base64 encoding character replacements#2694
Merged
Merged
Conversation
Signed-off-by: Jerome <107386741+jerome-ng@users.noreply.github.com>
jerome-ng
requested review from
SantanM,
brandantck,
mwaiyee and
p-hoffmann
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the URL-safe Base64 character mapping in the CLI’s base64UrlEncode helper, aligning it with the standard Base64url encoding rules (RFC 4648 / MDN reference) so generated tokens (e.g., JWT parts) use the correct URL-safe alphabet.
Changes:
- Corrected Base64url replacements to map
+→-and/→_inbase64UrlEncode.
mwaiyee
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Glossary/Base64#url_and_filename_safe_base64