Updated code to set default result viewer template for new studies #2648
Merged
amit-sharma-d4l merged 2 commits intoJun 19, 2026
Merged
Conversation
amit-sharma-d4l
requested review from
KangJingA,
SantanM,
hengxian-jiang,
p-hoffmann and
suwarnoong
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the System Admin “Study” page so newly created/local studies get a default Result Viewer template instead of an empty value, improving the out-of-box experience when launching/editing a viewer.
Changes:
- Default local studies’
viewerCodetoRESULT_VIEWER_TEMPLATEwhen the stored value is empty/whitespace-only.
| strategus_json: study.analysisSpec, | ||
| type: StrategusStudyType.LOCAL, | ||
| viewerCode: study.viewerCode ?? RESULT_VIEWER_TEMPLATE, | ||
| viewerCode: study.viewerCode?.trim() || RESULT_VIEWER_TEMPLATE, |
hengxian-jiang
approved these changes
Jun 8, 2026
amit-sharma-d4l
force-pushed
the
amit-sharma-d4l/result_viewer_default_template
branch
from
c8c3057 to
a22199f
Compare
amit-sharma-d4l
force-pushed
the
amit-sharma-d4l/result_viewer_default_template
branch
from
a22199f to
f4fc089
Compare
amit-sharma-d4l
deleted the
amit-sharma-d4l/result_viewer_default_template
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change sets the default result viewer template for a new study - previously it was empty.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)