helm charts update#2632
Open
p-hoffmann wants to merge 11 commits into
Open
Conversation
p-hoffmann
requested review from
SantanM,
brandantck,
csafreen and
suwarnoong
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the d2e-services Helm chart to align with the 0.16.0-beta release line, including new embedded WebAPI configuration and some config key renames/additions used by the deployed services.
Changes:
- Bump chart versions/dependency versions from
0.15.xto0.16.x. - Add Secret entries and Deployment env vars to configure the embedded WebAPI (datasource/security schemas + OIDC settings).
- Rename
AZ_AUTO_GRANT_RESEARCHER_BY_DATASET_CODEStoAUTO_GRANT_RESEARCHER_BY_DATASET_CODESand addIDP__AUTO_PROVISION_USERSconfig plumbing.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/d2e-services/templates/d2e-secrets.yaml | Adds new Secret keys for embedded WebAPI JDBC URLs. |
| charts/d2e-services/templates/d2e-deployment.yaml | Renames an env var, removes an unused secret mapping, and adds embedded WebAPI env configuration. |
| charts/d2e-services/templates/d2e-configmap.yaml | Renames config key and adds IDP__AUTO_PROVISION_USERS. |
| charts/d2e-services/ci/test-values.yaml | Updates CI values for 0.16 images/versions and adds new config values. |
| charts/d2e-services/charts/d2e-core/Chart.yaml | Bumps subchart version/appVersion to 0.16.0. |
| charts/d2e-services/Chart.yaml | Bumps main chart version/appVersion and d2e-core dependency version. |
| charts/d2e-services/Chart.lock | Adds a lock file for the d2e-core dependency at 0.16.0. |
Comment on lines
+38
to
+39
| WEBAPI__DATASOURCE__URL: "{{ printf "jdbc:postgresql://%s:5432/%s?currentSchema=webapi" .Values.global.secrets.POSTGRES_HOST .Values.global.secrets.POSTGRES_CONFIG_DB | b64enc }}" | ||
| WEBAPI__SECURITY__URL: "{{ printf "jdbc:postgresql://%s:5432/%s?currentSchema=webapi_security" .Values.global.secrets.POSTGRES_HOST .Values.global.secrets.POSTGRES_CONFIG_DB | b64enc }}" |
Comment on lines
+639
to
+640
| - name: SECURITY_ORIGIN | ||
| value: "*" |
| ACHILLES_THREAD_COUNT: {{ .Values.config.ACHILLES_THREAD_COUNT | quote }} | ||
| EXCLUDE_ANALYSIS_IDS: {{ .Values.config.EXCLUDE_ANALYSIS_IDS | quote }} | ||
| AZ_AUTO_GRANT_RESEARCHER_BY_DATASET_CODES: {{ .Values.config.AZ_AUTO_GRANT_RESEARCHER_BY_DATASET_CODES | quote }} | ||
| AUTO_GRANT_RESEARCHER_BY_DATASET_CODES: {{ .Values.config.AUTO_GRANT_RESEARCHER_BY_DATASET_CODES | quote }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)