Handle empty attrition before downsampling#196
Closed
anthonysena wants to merge 1 commit intodevelopfrom
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #196 +/- ##
========================================
Coverage 94.24% 94.24%
========================================
Files 22 22
Lines 6517 6517
========================================
Hits 6142 6142
Misses 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anthonysena
commented
Apr 13, 2026
| targetId, | ||
| maxCohortSize) { | ||
| if (maxCohortSize == 0) { | ||
| if (maxCohortSize == 0 || length(attrition$targetPersons) == 0) { |
Contributor
Author
There was a problem hiding this comment.
A note on this: attrition always returns a named list that has multiple names (i.e. targetPersons, comparatorPersons, etc) so checking length(attrition) > 0 will always return TRUE so I'm checking a specific list item length.
Member
|
Solved somewhat differently here, so closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to fix #195