You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if this is a good idea.
Spawn-Mode is still not the default upstream, since it's quite troublesome at times. The new default there is forkserver.
And for us, using fork still drastically speeds things up.
Since in spawn mode, each new process will have to re-load everything from disk, and can't re-use any existing resources.
So it's a severe performance penalty, and I also think it still has hidden broken edge cases which rely on pre-loaded global state.
Using fork is only deprecated when using it combined with threads.
And we're not using threads anywhere.
That's impossible to tell, but sadly quite possible.
I guess ideally we'd just be using threads instead of entirely new processes, but python global interpreter lock makes those not really workable and effectively nearly fully synchronize.
We could try experimenting with a free-threaded python build, which are a thing now and eliminate that lock.
But I think the various binary dependencies we have, like GDAL, do not support that mode at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes or at least addresses #1921