tests: set three hour time limit for workflows#1920
Open
gampnico wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Going through the workflow logs, it's rare for a workflow to exceed a 90 minute runtime. I've doubled this to be on the safe side. |
Member
|
mh, our tests currently take 30-40 minutes. That's the "models" test, which probably needs a rewrite as it is 3 times slower than the other tests. I don't think that we should ever exceed 90 mins and if we do, this is a bug that need addressing? |
Reduces timeout to 60 minutes. If we can speed up test_models, this could be reduced further.
…ub.com:gampnico/oggm into ON-62-prevent-hangs-on-github-workflows
Contributor
Author
|
Timer now runs for each test env rather than the total job with installs etc. I've set it to 60 minutes. Do you want me to take a look at optimising |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: ON-62
Refs: #1921
whats-new.rst