[18.0] [IMP] fastapi: show message for AccessError | MissingError#573
Open
ivantodorovich wants to merge 1 commit intoOCA:18.0from
Open
[18.0] [IMP] fastapi: show message for AccessError | MissingError#573ivantodorovich wants to merge 1 commit intoOCA:18.0from
ivantodorovich wants to merge 1 commit intoOCA:18.0from
Conversation
Contributor
|
Hi @lmignon, |
ivantodorovich
force-pushed
the
18.0-imp-fastapi-error-message
branch
from
54f3f87 to
197c2e0
Compare
Contributor
|
Thank you for the proposals @ivantodorovich. I understand the need. The current approach is very defensive and aims to avoid revealing the structure of the expected message in any way. In absolute terms, I am not against this change, Nevertheless this is a subject on which I would like to gather the opinions of as many people as possible. |
SilvioC2C
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's common to raise, for example,
MissingErrorwhen a related record is not found in a CREATE/WRITE operation.e.g.: let's say the endpoint allows to create partner, providing the
country_codeto reference a valid country. If there's no country record with such country_code, we want to raise a MissingError with a meaningful message for the api consumer (e.g.: "No country found with code: %s")