[19.0] [MIG] queue_job_batch: migrate + tests#842
Open
Conversation
This was referenced Oct 1, 2025
hoangtrann
reviewed
Oct 6, 2025
Contributor
hoangtrann
left a comment
There was a problem hiding this comment.
Everything looks good to me at first glance, I'll run the test locally and circle back
3 tasks
hoangtrann
suggested changes
Jan 5, 2026
Contributor
hoangtrann
left a comment
There was a problem hiding this comment.
Please update the test-requirements.txt and check if tests are now passing too
04b95b2 to
830a076
Compare
Scope: queue_job_batch, test_queue_job_batch
830a076 to
63933a5
Compare
Author
|
Hi @hoangtrann, thanks for the review.
CI is green now. @sbidoul |
len-foss
suggested changes
Jan 16, 2026
len-foss
left a comment
There was a problem hiding this comment.
I'm quite confused, but AFAICT you need lambdao-dev@21c4062 to have the migration working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Depends on
Summary
Temporary references
This will be removed once the base PR merges.
Pre-commit
Tests
test_queue_job_batch when queue_job/test_queue_job are not present.