Skip to content

[18.0][MIG] product_operating_unit: Migration to 18.0#830

Merged
OCA-git-bot merged 39 commits intoOCA:18.0from
komit-consulting:18.0-mig-product_operating_unit
Mar 27, 2026
Merged

[18.0][MIG] product_operating_unit: Migration to 18.0#830
OCA-git-bot merged 39 commits intoOCA:18.0from
komit-consulting:18.0-mig-product_operating_unit

Conversation

@hieulucky111
Copy link
Copy Markdown
Contributor

No description provided.

mara1 and others added 30 commits July 15, 2025 16:03
Co-Authored-By: Patrick Wilson <36892066+patrickrwilson@users.noreply.github.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/
Currently translated at 100.0% (7 of 7 strings)

Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/
Currently translated at 14.2% (1 of 7 strings)

Translation: operating-unit-16.0/operating-unit-16.0-product_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-16-0/operating-unit-16-0-product_operating_unit/ja/
This PR fixes an issue with the method operating_unit_default_get
where it would return an operating unit even for a company that was
not active, which would cause all sorts of issues

Steps to reproduce on runboat,
taking as example purchase_operating_unit:

- User has a default ou belonging to Company 1
- Switch to Company 2 (make sure Company 1 is not active at all)
- Try to create a Purchase Order

The issue arises because the operating_unit field is pre-compiled
on the PO with an Operating Unit whose company is inactive,
and the onchanges cannot find or access related data.
Copy link
Copy Markdown

@Quan-nhm Quan-nhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test LGTM

Copy link
Copy Markdown

@huan-tq huan-tq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module tested and LGTM.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Copy Markdown
Contributor

Can you check commit history? the last commit is a merge commit, it should not be.

@hieulucky111 hieulucky111 force-pushed the 18.0-mig-product_operating_unit branch from 703482a to b254bcc Compare March 27, 2026 10:10
@hieulucky111
Copy link
Copy Markdown
Contributor Author

Can you check commit history? the last commit is a merge commit, it should not be.

Hello, i have fixed the commit history.

@AaronHForgeFlow
Copy link
Copy Markdown
Contributor

@hieulucky111 ok thanks.

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-830-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 40a61e2 into OCA:18.0 Mar 27, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 8a6ec74. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.