[19.0][MIG] mail_tracking: Migration to 19.0 #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed
…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers
…s and contacts to bounce (OCA#133)
As regular users can't access this object.
* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances
On our server, queries based on "mail_tracking_event"."tracking_email_id" improved from 501,924 ms to 1,840 ms queries based on "mail_tracking_email"."mail_message_id" improved from 167,436 ms to 3,223 ms The last ones are run several times when a thread has many messages
Currently translated at 100.0% (82 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/fr/
For giving more priority to other buttons like the invoices one.
Currently translated at 96.3% (79 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/ca/
Or infinite recursions will happen on other `write` overwrites, like the one that happens on `mass_mailing_partner`.
In the forward port of the permission check, a column was dropped from the tuple, but the following code wasn't adapted to the new tuple length. For clarity sake we also name the tuple unpacking into proper variables. TT43453
- As the tracker img in the body is currently also used to set the X-Odoo-MailTracking-ID mail header we can remove the tag only after this is done - Added tests to check for the presence and absence of the tracking image tag depending on the new configuration parameter
- Recover the failed messages box in the mail.thread - Fix failed message box template issues - Remove dead code - Fix send_email() method signature - Fix patch methods js files paths - Update roadmap TT44683
The following changes were implemented:
1 - Added Failed Message component and related components to reuse the
Message component when rendering failed messages. This allows us to
dispose of the messagefailed JS model altogether, since failed messages
are now just regular messages that were marked as failed.
2 - Added Owl reactivity to failed message actions so that browser does
not have to be reloaded each time a message is marked as reviewed or
resent.
3 - Fixed 'Retry' and 'Set as reviewed' flows for failed messages.
4 - Fixed `Failed sent messages` filter on models by overriding `get_view`
instead of `_fields_view_get`
5 - Refactored folder structure to more closely resemble the `mail`
module's folder structure.
6 - Refactored module to utilize `Command` as a means to create, write,
etc. instead of `[0, ...]`, `[4, ...]`.
7 - Fixed and added unit tests.
8 - Removed dead/unused code from `v15`.
Add autovacuum to mail_tracking_email that removes old records based on new configuration variable mail_tracking_email_max_age_days. Due to possibly a large number of records to be deleted on first run, set a default limit of 5000 per run.
…peruser The previous condition to apply access restriction to mail tracking email records was not applied to every user having access rights settings. Hence, this could lead up to AccessError when trying to open the model's action through the web client. Since the access to these records is based on the same restrictions that are implemented for mail.message model in the mail module, we ended up having access error as there were records we were allowed to search but not to read, due to the restriction being more permissive in the case of mail tracking email. But since the check_access method of this model is actually checking if the user has access to the related mail.message, we need to have the same conditions to avoid such access error for users with settings access that are not superuser.
This prop was removed during the migration to 18.0 (974b492), probably by mistake, and yet causing this regression. The `onUpdate` prop is used here: https://github.com/OCA/mail/blob/b0226505/mail_tracking/static/src/core/chatter/chatter.xml#L34 And so the UI breaks whene trying to render a thread that contains failed messages. Traceback: ``` UncaughtPromiseError > OwlError Uncaught Promise > Invalid props for component 'FailedMessage': unknown key 'onUpdate' Occured on localhost:8069 on 2025-09-04 17:57:30 GMT OwlError: Invalid props for component 'FailedMessage': unknown key 'onUpdate' Error: Invalid props for component 'FailedMessage': unknown key 'onUpdate' at Object.validateProps (http://localhost:8069/web/assets/debug/web.assets_web.js:11207:19) (/web/static/lib/owl/owl.js:3214) at Chatter.template (eval at compile (http://localhost:8069/web/assets/debug/web.assets_web.js:13754:20), <anonymous>:30:17) (/web/static/lib/owl/owl.js:5761) at Chatter.template (eval at compile (http://localhost:8069/web/assets/debug/web.assets_web.js:13754:20), <anonymous>:194:30) (/web/static/lib/owl/owl.js:5761) at Fiber._render (http://localhost:8069/web/assets/debug/web.assets_web.js:9776:38) (/web/static/lib/owl/owl.js:1783) at Fiber.render (http://localhost:8069/web/assets/debug/web.assets_web.js:9768:18) (/web/static/lib/owl/owl.js:1775) at ComponentNode.updateAndRender (http://localhost:8069/web/assets/debug/web.assets_web.js:10564:19) (/web/static/lib/owl/owl.js:2571) ```
This is dead code since the Migration to 18.0 (974b492), when the `messaging_service_patch.esm.js` was removed and replaced by a new `mail_core_common_service_patch.esm.js`
…thod The controller that called this method was removed during the Migration to 16.0, OCA/social@ef73e2d This method is a left-over, it's not used anywhere since.
There's already a collapsable panel for failed messages in the chatter. Having this other panel is totally redundant, and it was a bit glitchy too.
Before this commit, when the user clicked on the icon of a message, the following error occurred: ValueError: not enough values to unpack (expected 4, got 0) Complementary to 86e188c
…s reviewed Before these changes, when the bus event was received in tabs that did not have the message open, an error appeared because the system was not able to find the message. After these changes, if the message is not available on the screen, the process continues because synchronization will not be necessary, and therefore the error will no longer occur.
quoc-pn
force-pushed
the
19.0-mig-mail_tracking
branch
from
0edcf49 to
506778b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove wizard model
mail.resend.messageand related code odoo/odoo@7e30fa8