[MIG] mail_partner_forwarding: Migration to 19.0 #108
Conversation
Currently translated at 100.0% (6 of 6 strings) Translation: social-17.0/social-17.0-mail_partner_forwarding Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_partner_forwarding/it/
Currently translated at 100.0% (6 of 6 strings) Translation: social-17.0/social-17.0-mail_partner_forwarding Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_partner_forwarding/es/
Currently translated at 66.6% (4 of 6 strings) Translation: mail-18.0/mail-18.0-mail_partner_forwarding Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_partner_forwarding/de/
matiasperalta1
force-pushed
the
19.0-mig-mail_partner_forwarding
branch
from
f3fecb6 to
8a056fc
Compare
matiasperalta1
force-pushed
the
19.0-mig-mail_partner_forwarding
branch
2 times, most recently
from
67815e3 to
d4050bf
Compare
|
This PR has the |
|
@pedrobaeza Hello! Could you merge it? |
|
/ocabot migration mail_partner_forwarding A PSC / maintainer should review it |
matiasperalta1
force-pushed
the
19.0-mig-mail_partner_forwarding
branch
from
d4050bf to
0488524
Compare
There was a problem hiding this comment.
Pull request overview
This PR migrates the mail_partner_forwarding module from a previous version to Odoo 19.0. The module enables partner mail forwarding functionality, allowing partners to designate a "forwarding partner" who will receive notifications intended for them.
Changes:
- Migration of module manifest to version 19.0.1.0.0
- Addition of models for partner and user mail forwarding with related field definitions
- Implementation of notification logic to forward messages to designated partners
- Inclusion of test coverage for the forwarding functionality
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
__manifest__.py |
Updated module version to 19.0.1.0.0 with proper metadata |
models/res_partner.py |
Added forwarding_partner_id field to partner model |
models/res_user.py |
Extended user model with forwarding_partner_id related field and self-access properties |
models/mail_thread.py |
Implemented notification recipient logic to include forwarding partners |
views/res_user_views.xml |
Added UI fields for forwarding partner in user forms |
views/res_partner_views.xml |
Added UI field for forwarding partner in partner form |
tests/test_mail_forwarding.py |
Added test case for message forwarding functionality |
tests/models/fake_order.py |
Created test model for testing mail functionality |
| Documentation files | Added README, usage instructions, and translation files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - Install it. | ||
| - Set a Forwarding partner in your partner. | ||
| - Your Forwarding partner also will be notify of your notifications |
There was a problem hiding this comment.
Grammatical error in this sentence. The verb "notify" should be in the past participle form "notified" to match the passive voice construction with "will be".
| - Your Forwarding partner also will be notify of your notifications | |
| - Your Forwarding partner also will be notified of your notifications |
| help="Messages will be forwarded only for partners that are followers but no" | ||
| " partners being notify because they belong to channel that is following" | ||
| " the thread", |
There was a problem hiding this comment.
The help text contains grammatical errors. The phrase "but no partners being notify" should be "but not partners being notified". The entire sentence is also unclear and could be improved for better understanding.
| help="Messages will be forwarded only for partners that are followers but no" | |
| " partners being notify because they belong to channel that is following" | |
| " the thread", | |
| help="Messages are forwarded only for partners who are direct followers, not" | |
| " for partners who are notified because they belong to a channel following" | |
| " the thread.", |
| data.update( | ||
| { | ||
| "id": partner.forwarding_partner_id.id, | ||
| "share": partner.partner_share, |
There was a problem hiding this comment.
The 'share' field is being set using 'partner.partner_share' (the original partner), but it should be using 'partner.forwarding_partner_id.partner_share' (the forwarding partner's share status). This could cause incorrect permission handling when the forwarding partner has a different share status than the original partner.
| "share": partner.partner_share, | |
| "share": partner.forwarding_partner_id.partner_share, |
| [build-system] | ||
| requires = ["whool"] | ||
| build-backend = "whool.buildapi" |
There was a problem hiding this comment.
The pyproject.toml declares whool as the build backend without pinning it to an immutable version, so every build will execute whatever code is served by the latest whool release from the registry, which is a classic software supply-chain risk. If an attacker compromises the whool package or its distribution channel, they could run arbitrary code during your build and tamper with produced artifacts. Consider pinning whool to a specific version or other immutable identifier, and updating it explicitly after review.
9 participants
No description provided.