Skip to content

Conversation

@astirpe
Copy link
Member

@astirpe astirpe commented Nov 13, 2025

No description provided.

@ and others added 30 commits November 11, 2025 18:42
* Modify scenarios to be compatible with python scenarios
* Voucher/statement related steps
* Deprecated step implementation
* Print report generation
* All tests green
* Mail + print of reminder
* Broken translations
* Fix failure to confirm invoice when both account_credit_control  and account_constraints are installed
* use except_orm instead of except_osv
* reindent code
* Cleanup
* use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template
* Address in mako template to make sure address is displayed
* Remove 'more info here' from report
* Add some css to reminder report and set texts taking the whole width of the document
* Add a subject in reminder report
* Report use precise mode by default
* date_entry fields on line model to be used by report or in next MP on filter group by
* reporting layer, + add hook function to get contact address
* credit control mail are not in plain text but send as attachement
* policy level name is now translatable as it is use in report and mail
* permission on invoices because onetomany widget load data even if hidden ...
* translation files + lang source
* french translation
* Translation + report invoice address layout
* Label Force credit control policy + french translation
* pep8 (space after comma, reduced length of lines)
* does not need to check if there is ids before calling unlink, it will return early
* remove unused import
* 'raise a new invoice' is a British English expression for 'issue a new invoice'
* scenarios: We fix year of scenario on 2013 to have reproducable setup, and ensure test maintnability. The credit control scenarios are based on base_finance setup scenario provided in the project OpenERP Scenarios. This setup provide a financial setup for 2012 2013. We also fix some value as precision computation has been improved in OpenERP.
* bug 1287072 Level calculation error if previous credit line is ignored
* unifing wizard views to respect UI guide lines
* credit control policy changer. Add a wizard on Invoice that will add a credit line and deprecate exisiting one on the invoice
* test to ensure that wizard run on customer invoice
* Scenario that test coherence of credit run after manually altering an invoice level
* multicurrency in communication
* ...
* Partner Form view: field "credit_limit" is defined in account module, not base
* Minimal Danish translation
* Do not link e-mails to Transient records

Transient records are deleted periodically so res_id will point to ID which
does not exists. And when reading email records system would also check if
res_id can be read by user which would cause an exception because res_id
might not exist at that point.
This fix seems ugly, but I cant figure why I've a security error when an invoice is  displayed for a user without right on credit_control despite the attribute 'groups' declared on the field definition in the form view
(cherry picked from commit 811310fd06ca8589fa8e87da6b8bdaea403bf660)

[MIG] Improve the code and fix some bugs

(cherry picked from commit 5bcdfe3f748884d650120f76d1642b820d0a800b)

[FIX] Change the parent for the menu Credit Control (the previous parent menu was not in the Odoo standard)

(cherry picked from commit 826257ce7b5248956d838cae9c94a012d550327e)

[FIX] Fix a lot of errors to respect pep8

(cherry picked from commit bed6cf35d665eea32122c91d33322af141053f29)

[FIX] Respect PEP8

(cherry picked from commit 6353eef0dce1bfe5db8a38d3410d1cc7f833fa10)
(cherry picked from commit c32d167ac05ebef2256e3cb5919c13e7b9229fdf)
…useless spaces, ...) and fix some small bugs

(cherry picked from commit efd9e9f8efe9a5e8da791d179b5a5d57710a31c3)

[FIX] Add space to respect PEP8

(cherry picked from commit 06c93c610646bb4269f303c3a7a55700cc6dfd1f)

[FIX] Replace the field "full_reconcile_id" by "reconciled" in a search domain on account.move.line

(cherry picked from commit cf2cfd43e34dff9eef2571b87de777a183c220c0)
(cherry picked from commit 7fa1b0ac883914f3cdfcaaa1a00016a35cced368)

[IMP] Add some unitest and fix a bug with exceptions

(cherry picked from commit c2f34ecd06fa5ba093084cf32f35c722c5866ff5)

[FIX] Reindent line

(cherry picked from commit b643a48f86b20ed6496f2e08366a407095d1540b)

[IMP] Add some new unittests

(cherry picked from commit f118e2391de3b443558d26186fe44f55a7f0b9c4)

[IMP] Add encoding in each python files

(cherry picked from commit 9599a88303b921c8e73174db61318f6dc9f02017)
victoralmau and others added 24 commits November 11, 2025 18:42
…nd in the report for correct visualization

TT55608
Currently translated at 100.0% (281 of 281 strings)

Translation: credit-control-18.0/credit-control-18.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_credit_control/it/
Currently translated at 100.0% (281 of 281 strings)

Translation: credit-control-18.0/credit-control-18.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_credit_control/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-18.0/credit-control-18.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_credit_control/
Currently translated at 100.0% (276 of 276 strings)

Translation: credit-control-18.0/credit-control-18.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_credit_control/it/
…as blacklisted

Before, if the contact email is balcklisted, the control lines just appear as "queued"
forever, even if the mail was canceled. This is due to postprocess not being called.
The root tag for the message could be a span in certain cases,
so these are excluded from the check.

The email_from is defined in the template, so it should be set on the
company to be able to send it.
…ckground"

This reverts commit 834e7ad.

Commit:
odoo/odoo@543a3ad

Contains the comment that
```
```

So a thread is generally assumed to take at most 2 cursors.
Because of this, it is essentially a very bad idea to open an unlimited number of cursors.
(On a decently sized DB, about 400 lines would be processed in parallel...)

Because things are launched in their own cursor, this doesn't impact the main request,
so the run is marked as done and all lines are marked as queued,
despite the emails never being scheduled.

There is already a way to manage this kind of cases in the OCA that is called `queue_job`.
Therefore this is the module that should handle this.

If for some reason one would still want the threaded code nonetheless,
it should be put in a custom project module, as it relies on some environment hypothesis
that can't be tested from within the code.

Note that one test is split into two; although it is better to avoid code duplication,
the test was cheating the setup, and therefore not representative of the real user flow is
when users click on the interface buttons.
…_control_queue_job initialized

Since tests first initialize modules then run the tests,
this module needs to pass the context key queue_job__no_delay
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: credit-control-18.0/credit-control-18.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_credit_control/
Currently translated at 74.0% (203 of 274 strings)

Translation: credit-control-18.0/credit-control-18.0-account_credit_control
Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_credit_control/fr/
@astirpe astirpe marked this pull request as ready for review November 13, 2025 09:02
@astirpe astirpe force-pushed the 19_mig_account_credit_control branch from b080962 to 97bd24f Compare November 14, 2025 09:01
@yvaucher
Copy link
Member

Could you give a review to #522

(It was there since a while from #488 )

@astirpe astirpe force-pushed the 19_mig_account_credit_control branch from 97bd24f to c18460a Compare November 17, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.