Repository navigation
fix: run migrations on container start only - #130
Merged
Merged
Conversation
The UI ran migrations on every request, writing the lock file and two app.log lines each time, while startup never ran them. Clear a stale lock left by an interrupted start.
nzxl101
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #121:
loader.phponly ran$proxyDb->migrations()for UI requests, so container startup never ran them and every UI request did, creating and deletingmigration-in-progress.txtand writing two lines toapp.logeach time.startup.phpdefinesIS_STARTUPbefore loadingloader.php, and migrations only run when it is set (the crons also loadloader.phpfrom the CLI, so a CLI check would not work)migration-in-progress.txtis deleted before migrating. Nothing else runs that early, so it can only be from a start that died mid migration, and it would otherwise block migrations for goodTested:
/config: database created and migrations 001 to 008 applied at startup, no lock file leftapp.log; with feat: auto-refresh the log viewer #121,sse.phppolls add nothing toapp.log