test(e2e): skip Suricata in smoke fixture to fix processing-timeout flake#570
Conversation
…flake The llm-error smoke test uploads a pcap and waits up to 60s for it to reach 'completed'. Suricata defaults to on at the API, and loading the Emerging Threats ruleset adds ~60s per analysis regardless of capture size, parking the test right at its deadline (~62s observed for a 38-packet fixture) — so it flakes when CI is slightly slow. These tests only need a completed file to reach the Story/Filter tabs, so disable Suricata in the upload helper. Fixture setup drops from ~60s to ~2s. Root-cause perf issue tracked in #569. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the end-to-end test helper in frontend/e2e/helpers.ts to disable Suricata (enableSuricata: 'false') during fixture upload and processing. This change is intended to prevent smoke tests from timing out and becoming flaky due to the overhead of loading the Emerging Threats ruleset. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe end-to-end fixture upload helper now explicitly disables Suricata processing and documents that ruleset processing can make smoke-test deadlines flaky. ChangesFixture upload processing
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The
llm-error.spec.tssmoke test (E2E Smoke Tests / Playwright smoke tests) has been flaky, failing in fixture setup with:It first surfaced on the version-sync PR #568 (
v0.1.1-182-g75ce6ee) — the only recent sync PR that touched an E2E-trigger path (docker-compose.yml), so it was the first sync to re-run the suite. It is not a #567 regression; #567 only nudged a test that was already sitting on the edge.Root cause
uploadAndProcessFixtureuploads a pcap and polls up to 60s forcompleted.enableSuricatadefaults totrueat the API, and Suricata reloads the full Emerging Threats ruleset on every analysis (~60s regardless of size), so processing lands right at the deadline and tips over when CI is slightly slow.Measured against the running stack (
ftp.pcap, 9 KB / 38 packets):Fix
The LLM-error tests only need a completed file to reach the Story/Filter tabs — they don't exercise IDS output. Upload the fixture with
enableSuricata: 'false'. Fixture setup drops from a flaky ~60s to ~2s.Local run:
2 passed (3.4s).Follow-up
The underlying "Suricata adds ~60s to every upload" performance problem is tracked separately in #569.
Summary by CodeRabbit