Skip to content
This repository was archived by the owner on Aug 12, 2026. It is now read-only.

config: allow enabling numlock on startup - #86

Merged
NotAShelf merged 1 commit into
NotAShelf:masterfrom
asogii:feat_numlock
Jul 26, 2026
Merged

NotAShelf merged 1 commit into
NotAShelf:masterfrom
asogii:feat_numlock

Conversation

@asogii

@asogii asogii commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

added a new option to enable numlock at launch. it supports configuration via file, environment variables, or the --numlock parameter. defaults to false

@NotAShelf

Copy link
Copy Markdown
Owner

I have some nitpicks, but they're not necessarily your fault. It only occurred to me now that how we handle config parsing is a bit fragile and misleading to contributors.

Could you please reword your commit message? This repository does not use conventional commits. You should be able to find examples in the git log.

@asogii

asogii commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

I have some nitpicks, but they're not necessarily your fault. It only occurred to me now that how we handle config parsing is a bit fragile and misleading to contributors.

Could you please reword your commit message? This repository does not use conventional commits. You should be able to find examples in the git log.

Sorry for the late reply and thanks for the feedback. I've updated the commit message to follow the repo's format (config: enable numlock on startup) and rebased the branch on latest master.

Let me know if there's anything else you'd like me to tweak with the config handling!

@NotAShelf NotAShelf changed the title feat: added support for enabling numlock on startup config: allow enabling numlock on startup Jul 26, 2026
@NotAShelf
NotAShelf merged commit 097848a into NotAShelf:master Jul 26, 2026
2 of 3 checks passed
@NotAShelf

Copy link
Copy Markdown
Owner

Needs a changelog entry actually, but I can add it myself. Thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants