#3896 added term_definition and sponsor logoImageId to schema #3897
Conversation
staysgt
changed the title
chpy04
left a comment
chpy04
left a comment
There was a problem hiding this comment.
Would like to talk about how this will actually work in the frontend. This aligns with the admin tools, but Im not sure it aligns with what the frontend actually looks like in the epic
src/backend/src/prisma/schema.prisma
Outdated
| type Definition_Type | ||
| buttonText String? | ||
| buttonLink String? | ||
| subTerms Term_Definition[] @relation("TermDefinitionSubTerms") |
There was a problem hiding this comment.
waiting on convo from naisha, but I think this would make the ui on the frontend for editing a pain so I'd rather not support this
chpy04
left a comment
chpy04
left a comment
There was a problem hiding this comment.
Need description field on projects for same thing as divisions
| usersOnboarding User[] @relation(name: "onboardingTeamTypes") | ||
| usersOnboarded User[] @relation(name: "onboardedTeamTypes") | ||
| definition Guest_Definition? @relation(fields: [definitionId], references: [definitionId]) | ||
| definitionId String? |
There was a problem hiding this comment.
For these definitions as well as the project ones, I think it makes more sense to have the information encoded within the team type / project structure instead of linking to the guest definition which would give it more flexibility than we actually want. The buttons will always take the user to a page with that divisions projects. Because of this I think a simple description text field here is all we need and it keeps the scope on guest definiitions down
| userCreatedId String | ||
| organization Organization @relation(fields: [organizationId], references: [organizationId]) | ||
| organizationId String | ||
| teamTypes Team_Type[] |
There was a problem hiding this comment.
add int for order. We can talk about implementation later but you can also reference the onboarding because a very similar thing is done there
Changes
Added a term_definition model and added a logoImageId field to the sponsor model in the schema.
Notes
The term_definition is to hold the terms and definitions on the admin tools page. The logoImageId is to hold the image for the guest sponsors page.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3896